Adds auto-configuration of property useCodeAsDefaultMessage of MessageSource #10466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
requested changes
Oct 2, 2017
There was a problem hiding this comment.
Sorry but it looks like that PR changed the formatting of the file.
Can you please rework the PR to use the same formatting rules so that only the things you've actually changed are included in the commit?
Also, please squash your changes to a single commit. You can push force on your existing branch to update this PR.
spring-projects-issues
added
the
status: waiting-for-triage
|
@snicoll I apologies for the trouble. Line endings were changed to CRLF. I have recommitted the changes with proper formatting. |
snicoll
added
priority: normal
type: enhancement
snicoll
approved these changes
Oct 2, 2017
snicoll
pushed a commit
that referenced
this pull request
Oct 2, 2017
snicoll
added a commit
that referenced
this pull request
Oct 2, 2017
* pr/10466: Polish Polish "Adds support for useCodeAsDefaultMessage" Adds support for useCodeAsDefaultMessage
|
@snicoll Any plan to integrate this fix in 1.5.x ? I can backport it, if needed. |
|
No, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10146 by adding auto configuration of
useCodeAsDefaultMessageinMessageSourceAutoConfiguration